[JENKINS-59846] Reintroduce automatic hyperlinking of URLs in JUnit test output, safely #669
+110
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #481 by reintroducing automatic linkifying of URLs in JUnit test output. After being converted into tags, the links are passed through an HTML sanitization library to ensure they are not malicious.
This is a slight rework of #555 that resolves some of the problems that the sanitizer was causing by only passing the hyperlinks through the sanitizer, while using the classic simple sanitization method for all other output text.
Some screenshots to illustrate what this looks like in practice:
Test code:
Test result page in Jenkins:
Testing done
mvn verify
and verified that it succeededSubmitter checklist