Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make queue item expiration configurable via Java system property #9901

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-beck
Copy link
Member

Related to https://issues.jenkins.io/browse/JENKINS-26228, https://issues.jenkins.io/browse/JENKINS-31039.

The cache we use doesn't seem to allow for a guaranteed minimum duration without allowing infinite growth, but tunable settings seem like a start (and in the future, increase defaults). I chose 10k as the max size to support busy instances without allowing them to go oom too easily, but this value is a wild guess. Even significant increases in duration seem to be the primary reason for cache eviction.

For now for the PR build and to allow feedback on approach.


See JENKINS-XXXXX.

Testing done

Ran java -Dhudson.model.Queue.LEFT_ITEMS_CACHE_EXPIRATION_SECONDS=20 -jar jenkins.war and confirmed items disappeared (/queue/item/NN/ 404) ~20 seconds after becoming LeftItems.

Proposed changelog entries

  • human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant