Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Jenkins-36718 - Fix DM_DEFAULT_ENCODING scanned by spotbugs #9784

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

programbeginnerTW
Copy link
Contributor

@programbeginnerTW programbeginnerTW commented Sep 25, 2024

See JENKINS-36718.

Testing done

  • Clean compiled
  • Manually tested Jenkins core as well as spotbugs to ensure no DM_DEFAULT_ENCODING remains.
  • Specify using UTF-8 encoding to prevent relative problems.
  • Run all SpotBugs check to proof the warnings were tackled.

Proposed changelog entries

  • Fixed encoding issues in consoleNote.java, WindowsServiceLifecycle.java, and Textfile.java by specifying UTF-8 encoding instead of system default.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@programbeginnerTW
Copy link
Contributor Author

@oleg-nenashev , I saw this issue on Jira and mentioned you in the article. JENKINS-36718
Could you review this, please 🥹

@programbeginnerTW programbeginnerTW marked this pull request as draft November 3, 2024 01:18
@programbeginnerTW programbeginnerTW marked this pull request as ready for review November 3, 2024 01:20
@programbeginnerTW programbeginnerTW marked this pull request as draft November 3, 2024 01:38
@programbeginnerTW programbeginnerTW marked this pull request as ready for review November 3, 2024 01:48
@oleg-nenashev oleg-nenashev self-requested a review November 3, 2024 09:45
@oleg-nenashev
Copy link
Member

@programbeginnerTW thank for the pull request. I'm yet to return to the Jenkins core maintenance after a long sabbatical. I will try to take a look when I have a bit of a time, but there are also many other core maintainers around so you shouldn't depend on my response

Generally, I need to refresh my memory what will the agreements on default encoding. Using anything except system default is a potential breaking change. Maybe this it is safer to just use default

1 similar comment
@oleg-nenashev
Copy link
Member

@programbeginnerTW thank for the pull request. I'm yet to return to the Jenkins core maintenance after a long sabbatical. I will try to take a look when I have a bit of a time, but there are also many other core maintainers around so you shouldn't depend on my response

Generally, I need to refresh my memory what will the agreements on default encoding. Using anything except system default is a potential breaking change. Maybe this it is safer to just use default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants