-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update progressiveText.jelly with documentation tag #10085
base: master
Are you sure you want to change the base?
Conversation
The `st:documentation` and `st:attribute` tags are used by Jenkins Development Support plugin for autocomplete and documentation lookup.
Sure, its flawed and needs to be fixed. But what about content? Does any tool rely on those JSP style comments? Or should I go forward and try and replace all of them with |
Not that I'm aware of, content looks good and yes good to use st:documentation etc everywhere |
The comment was replaced with a documentation tag. A few gaps were filled to the best of my understanding.
It turned out there were only a few. I addressed the comments and updated the other two tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think Alex went through at some point and fixed most of this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duemir this PR LGTM.
The
st:documentation
andst:attribute
tags are used by Jenkins Development Support plugin for autocomplete and documentation lookup.I did this quick change in the GitHub editor as much as a conversation starter as the suggestion. There more instances like this, so there is likely more work required. Tags documented like this get a benefit of autocompletion and documentation and deprecated attribute validation from the IntelliJ plugin. The more tags are update with unsupported documentation format the less helpful IntelliJ plugin becomes.
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist