-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oklch
for the Jenkins UI
#10078
base: master
Are you sure you want to change the base?
Use oklch
for the Jenkins UI
#10078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does dark theme need a similar PR?
(I haven't run this yet but the comparison screenshots look identical to me
It doesn't need one (e.g. still looks fine), but I want to create one to bring over
Yeah the hue of the UI is very slightly different, not intended to be noticeable by the user but it does make our UI's theme more consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like unsupported by HTMLUnit 😢
Oh nice: HtmlUnit/htmlunit-cssparser#82
I've really wanted to do this one for a while, combination of waiting for tooling and browser support to catch up. This PR uses
oklch
for colours to ensure that our palette is consistent (e.g. colours used for tables, cards, buttons all inherit from the same colour and only have to be defined once).This change won't have much visual impact on Jenkins, but it will ensure that things are consistent in a way that wasn't easy to do so before. You'll notice slight hue changes here and there across the UI, and actual colours will pop a little bit more depending on if your display supports it.
This change also makes it easier for theme developers, say if a developer wanted to develop an 'Accent colour' plugin they'd only need to update one variable (
--accent-color
) and Jenkins would reflect that across the UI.Changing the accent colour property can have quite an impact on the overall interface now
Why
oklch
?From https://evilmartians.com/chronicles/oklch-in-css-why-quit-rgb-hsl
Testing done
Proposed changelog entries
oklch
for the Jenkins UIProposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist