Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerolling of Inject environment variables during buildstep #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickveenhof
Copy link
Contributor

This change allows us to use the outputs of a Cloudformation build step in the following build step. It also cleans up the way environment variables are created since dashes are not allowed in an environment variable but if the stackname had a dash it could happen that this became part of the environment variable key. Also I added environment variables without the prefix since stack names can also be generated using environment variables and it becomes really hard to then use those variables as parameters. Without the prefix, that becomes easier WITH the risk that the next stack could overwrite those variables.

Reroll of #22 , see details there

@phpboyscout
Copy link

hi @nickveenhof I was using a hastily patched version of #22 to make it possible to access the outputs inside post build actions... does this re-roll provide this functionality at all?

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@nickveenhof
Copy link
Contributor Author

Should be exactly the same, if you are in doubt. Try to clone the repo, do mvn install and try it out :-) best way to test

@nickveenhof
Copy link
Contributor Author

Any update here?

@nathanagood
Copy link
Contributor

I'm going to try to test and take care of these over this weekend for a release on Tuesday. Just so you know, I'm going to update the README and after taking care of these outstanding PRs insist that 1.) there is a Jira ticket open that the PR references and 2.) that any changes have unit tests that verify their functionality. It will be a change from how this was maintained but both are common practice in software development and therefore I think neither criteria is unreasonable. Best regards!

@phpboyscout
Copy link

Hi @nickveenhof

I can confirm that your update for variables works during build steps but is not present in post build tasks

@ghost
Copy link

ghost commented Jun 6, 2016

any idea if this when this will be merged and/or released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants