Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73388] Allow alternative implementation for GitHub App credentials #796

Merged

Conversation

jeromepochat
Copy link
Contributor

@jeromepochat jeromepochat commented Jul 9, 2024

This encapsulate fields making possible to extend GitHubAppCredentials to retrieve properties from an alternative storage instead of field values.

Pseudo code:

class AlternativeGitHubAppCredentials extends GitHubAppCredentials {

    @Override
    public getAppID() {
        return retrieveFromExternalSystem("appId");
    }

    @Override
    public getPrivateKey() {
        return retrieveFromExternalSystem("privateKey");
    }
}

See JENKINS-73388 for further information.

Copy link
Contributor

@car-roll car-roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@car-roll car-roll merged commit 5a78598 into jenkinsci:master Jul 17, 2024
14 checks passed
@jeromepochat jeromepochat deleted the JENKINS-73388-fields-encapsulation branch July 17, 2024 14:40
@jeromepochat jeromepochat restored the JENKINS-73388-fields-encapsulation branch July 17, 2024 14:40
@jeromepochat jeromepochat deleted the JENKINS-73388-fields-encapsulation branch July 17, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants