Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-65493] Allow excluding by topics #789

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[JENKINS-65493] Allow excluding by topics #789

wants to merge 3 commits into from

Conversation

ingwarsw
Copy link

@ingwarsw ingwarsw commented Jun 11, 2024 •
edited
Loading

Description

Allow excluding topics by prepending them with - sign.

See JENKINS-65493 for further information.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@ingwarsw ingwarsw marked this pull request as ready for review June 11, 2024 12:16
@ingwarsw ingwarsw requested a review from a team as a code owner June 11, 2024 12:16
ingwarsw
ingwarsw commented Jun 11, 2024
View reviewed changes
src/main/resources/org/jenkinsci/plugins/github_branch_source/TopicsTrait/help-topicList.html
<p>Specify a comma-separated list of <strong>topics</strong> to filter for repositories that have (you can prefix topic with `-` to have it <u>excluded</u>) <u>all of them</u>.</p>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone have better idea for that help message It surely could be updated.

@ingwarsw ingwarsw changed the title Allow exluding by topics [JENKINS-65493] Allow excluding by topics Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ingwarsw