Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-72894 - Adding support to more than 1000 repositories #773

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

guilhermemotadock
Copy link

Description

Adding support to more than 1000 repositories. See
JENKINS-72894 for further information.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@guilhermemotadock guilhermemotadock requested a review from a team as a code owner March 19, 2024 18:30
jglick
jglick previously requested changes Mar 19, 2024
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@jglick jglick dismissed their stale review March 19, 2024 20:04

addressed (I am not reviewing code changes at this time)

@jglick jglick requested review from a team and removed request for jglick March 19, 2024 20:04
@jglick jglick removed their request for review March 20, 2024 17:17

// Only the first 1000 search results are available
if (ghRepositorySearchBuilder.list().getTotalCount() > 1000) {
return org.listRepositories(100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like this is ignoring all the search settings above.
There is also redundant code in these two new methods that can be reduced.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, the query above only returns the first 1000 records. This is a github limitation.
The query also returns the number of existing records and this value is used to make a decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants