Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always show the GitHub endpoint selection #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Mar 7, 2021

Description

so users are aware that they must add a new endpoint in configiuration

Standardize the docs for apiUri

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@carlossg
Copy link
Contributor Author

carlossg commented Mar 7, 2021

I checked the source and app credential rendering, but not sure in what page is GitHubSCMNavigator used?

Comment on lines +4 to +6
<f:entry title="${%API endpoint}" field="apiUri">
<f:select/>
</f:entry>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this drop down will also include github.com if the endpoint list is empty. Or did that change at some point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not include github.com

Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were saying this path is deprecated anyway as of #262 .

In #254, I attempted to address a bad behavior in JobDSL caused by #262 but that lost steam.

Could you talk a bit more about how this is an improvement?

@bitwiseman
Copy link
Contributor

@carlossg Ping?

@carlossg
Copy link
Contributor Author

Today if you add a new GitHub App credential there is no option to select a GitHub enterprise installation. You must know that you need to go to settings - manage jenkins and add the endpoint.
This makes it explicit, it shows the github.com endpoint and in the help it tells you how to add a new endpoint, so it saves time to new users

so users are aware that they must add a new endpoint in configuration

Standardize the docs for apiUri
@carlossg
Copy link
Contributor Author

before:

Screenshot 2023-12-27 at 14 55 50

after:

Screenshot 2023-12-27 at 15 03 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants