Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demux Github webhook events based on included regions #282

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

salmaanrizvi
Copy link

@salmaanrizvi salmaanrizvi commented Feb 5, 2020

  • Description:
    • When Jenkins has many multibranch pipelines configured for a single GitHub repository webhook event, often many multibranch pipeline events are missed or not picked up due to the significant load that scanning a repository can add. Adding the ability to cache the branch / latest built head commit on a per job basis effectively reduces the amount of load Jenkins master has to deal with and reduces the number of "missed" webhook events.
    • Demuxing / caching using an ant file pattern

I'm not sure this is the best way to do this, but would love to know of any cases / pitfalls I may have not considered properly in this implementation.

@@ -0,0 +1 @@
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.5.4/apache-maven-3.5.4-bin.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to make this a separate PR and use the latest version, 3.6.3 currently

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salmaanrizvi
I agree with @timja here. I'd rather the discuss the pros/cons of adding maven wrapper in another PR.

import java.nio.channels.*;
import java.util.Properties;

public class MavenWrapperDownloader {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? What?

Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salmaanrizvi
This looks like an interesting and useful change, but it needs some changes.

  • Merge with current master
  • The maven wrapper addition needs to be a separate PR
  • More comments either in the PR and or in the code for what the code is doing.
  • Add tests

I've also started a gitter.im channel for this plugin. Happy to discuss over there as well.

@jglick
Copy link
Member

jglick commented Mar 4, 2021

Is this not basically JENKINS-58637 and handled already by https://github.com/jenkinsci/multibranch-build-strategy-extension-plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants