Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NettyDockerCmdExecFactoryCompat #1021

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Remove NettyDockerCmdExecFactoryCompat #1021

merged 1 commit into from
Sep 28, 2023

Conversation

basil
Copy link
Member

@basil basil commented Sep 28, 2023

As far as I can tell nothing in the ecosystem is using this class anymore. This plugin has long ago switched from Netty to Apache HttpClient 5.x.

@basil basil added the removed label Sep 28, 2023
@basil basil requested a review from a team as a code owner September 28, 2023 20:44
MarkEWaite
MarkEWaite approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MarkEWaite MarkEWaite merged commit f3142c3 into jenkinsci:master Sep 28, 2023
16 checks passed
@basil basil deleted the netty branch September 28, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @MarkEWaite