Add default settings to Build Monitor Views #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Thanks for the PR! Looks good to me, but I will wait a day or two in case @jan-molak wants to comment.
|
Thanks for working on this, @dcendents, and thanks for the ping @basil. |
|
@dcendents There are 4 new test failures in the CI build for this PR. I ran the build twice, and the 4 new failures were present both times. |
|
@basil Sorry my bad I changed 2 default values for the configuration page at the last minute and I didn't run the tests again. |
|
Nice one, @basil - thanks for picking it up! I was going through the changes on my phone and didn't notice 🤦🏻♂️ |
cgiorgetta
added a commit
to cgiorgetta/jenkins-build-monitor-plugin
that referenced
this pull request
May 3, 2022
* [JENKINS-66299] Prepare Build Monitor View for core Guava upgrade * Corrected gitignore * Created a basic pipeline * Renamed main worflow so that it aligns with GitHub conventions * Auto-download chromedriver * Updated Serenity BDD * Added the new build badge * Use HTTPS URLs in `package-lock.json` * Update baseline to 2.249.3 (jenkinsci#483) * Prefer library versions from less4j to minimize risk * ci: set the version number automatically * Read new version into env * print new version in the log * ci: corrected the order of steps in the pipeline * ci: automatically create a release branch * ci: configure git for automated release branch creation * ci: corrected a typo * ci: corrected git checkout * Prepeared for the release * configure release profile * Added publish step * Corrected release config * Corrected registry url * Corrected path to POM * Corrected registry url * Corrected the publish command * Correct distribution management url * Update main.yaml * Removed the unused travis config * Removed the unused travis config * Corrected release script * Debug maven release process * Corrected config * Set path to settings * Ensure env variables are passed to the release script * fix the acceptance tests make sure it runs on windows as well * fix the remaining acceptance tests on latest * move acceptance tests in a single project * refactor acceptance tests with parameters for jenkins versions to test * renaming class to BuildMonitorAcceptanceTest * update to jenkins 2.289.1, use java.util.function.Predicate * Remove all usages of Guava * Remove PowerMock * Add Dependabot configuration * Increase open pull requests limit * Ignore Jetty for now * Bump joda-time from 2.10.5 to 2.10.13 Bumps [joda-time](https://github.com/JodaOrg/joda-time) from 2.10.5 to 2.10.13. - [Release notes](https://github.com/JodaOrg/joda-time/releases) - [Changelog](https://github.com/JodaOrg/joda-time/blob/master/RELEASE-NOTES.txt) - [Commits](JodaOrg/joda-time@v2.10.5...v2.10.13) --- updated-dependencies: - dependency-name: joda-time:joda-time dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump bytebuddy.version from 1.11.19 to 1.12.1 Bumps `bytebuddy.version` from 1.11.19 to 1.12.1. Updates `byte-buddy-agent` from 1.11.19 to 1.12.1 - [Release notes](https://github.com/raphw/byte-buddy/releases) - [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md) - [Commits](raphw/byte-buddy@byte-buddy-1.11.19...byte-buddy-1.12.1) Updates `byte-buddy` from 1.11.19 to 1.12.1 - [Release notes](https://github.com/raphw/byte-buddy/releases) - [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md) - [Commits](raphw/byte-buddy@byte-buddy-1.11.19...byte-buddy-1.12.1) --- updated-dependencies: - dependency-name: net.bytebuddy:byte-buddy-agent dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: net.bytebuddy:byte-buddy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump jacoco-maven-plugin from 0.6.4.201312101107 to 0.8.7 Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.6.4.201312101107 to 0.8.7. - [Release notes](https://github.com/jacoco/jacoco/releases) - [Commits](https://github.com/jacoco/jacoco/commits/v0.8.7) --- updated-dependencies: - dependency-name: org.jacoco:jacoco-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump xstream from 1.4.17 to 1.4.18 in /build-monitor-acceptance Bumps [xstream](https://github.com/x-stream/xstream) from 1.4.17 to 1.4.18. - [Release notes](https://github.com/x-stream/xstream/releases) - [Commits](https://github.com/x-stream/xstream/commits) --- updated-dependencies: - dependency-name: com.thoughtworks.xstream:xstream dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Bump buildgraph-view from 1.0 to 1.3 Bumps [buildgraph-view](https://github.com/jenkinsci/buildgraph-view-plugin) from 1.0 to 1.3. - [Release notes](https://github.com/jenkinsci/buildgraph-view-plugin/releases) - [Commits](jenkinsci/buildgraph-view-plugin@buildgraph-view-1.0...buildgraph-view-1.3) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:buildgraph-view dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump claim from 2.8 to 2.18.2 in /build-monitor-plugin Bumps [claim](https://github.com/jenkinsci/claim-plugin) from 2.8 to 2.18.2. - [Release notes](https://github.com/jenkinsci/claim-plugin/releases) - [Changelog](https://github.com/jenkinsci/claim-plugin/blob/master/CHANGELOG.md) - [Commits](jenkinsci/claim-plugin@claim-2.8...claim-2.18.2) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:claim dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Upgrade Jackson to latest * Ignore CLI * Bump slf4j-simple from 1.7.19 to 1.7.32 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.19 to 1.7.32. - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_1.7.19...v_1.7.32) --- updated-dependencies: - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump less4j from 1.8.0 to 1.17.2 Bumps [less4j](https://github.com/SomMeri/less4j) from 1.8.0 to 1.17.2. - [Release notes](https://github.com/SomMeri/less4j/releases) - [Commits](SomMeri/less4j@less4j-1.8.0...less4j-1.17.2) --- updated-dependencies: - dependency-name: com.github.sommeri:less4j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump view-job-filters from 1.26 to 2.3 Bumps view-job-filters from 1.26 to 2.3. --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:view-job-filters dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump release-candidate-maven-plugin Bumps [release-candidate-maven-plugin](https://github.com/smartcodeltd/release-candidate-maven-plugin) from 1.0-201603091838.01dbbbf to 1.0-201605132325.9e7d5be. - [Release notes](https://github.com/smartcodeltd/release-candidate-maven-plugin/releases) - [Commits](https://github.com/smartcodeltd/release-candidate-maven-plugin/commits) --- updated-dependencies: - dependency-name: com.smartcodeltd:release-candidate-maven-plugin dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Bump badge from 1.2 to 1.9 Bumps [badge](https://github.com/jenkinsci/badge-plugin) from 1.2 to 1.9. - [Release notes](https://github.com/jenkinsci/badge-plugin/releases) - [Changelog](https://github.com/jenkinsci/badge-plugin/blob/master/CHANGELOG.md) - [Commits](jenkinsci/badge-plugin@badge-1.2...badge-1.9) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:badge dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump maven-aether-provider from 3.2.5 to 3.3.9 (jenkinsci#511) * Bump maven-aether-provider from 3.2.5 to 3.3.9 Bumps maven-aether-provider from 3.2.5 to 3.3.9. --- updated-dependencies: - dependency-name: org.apache.maven:maven-aether-provider dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Basil Crow <[email protected]> * Bump http-proxy from 1.17.0 to 1.18.1 in /build-monitor-plugin Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.17.0...1.18.1) Signed-off-by: dependabot[bot] <[email protected]> * transform less to css at compile time instead of runtime * Remove unnecessary dependencies * Remove unused phantomjs dependency * Remove unnecessary optional dependencies * Remove optional dependency on buildgraph-view * Reduce usages of deprecated methods * Replace C-style array declaration with Java-style array declaration * Replace Optional.isPresent with functional-style expression * Use StandardCharsets where possible * Remove redundant "extends Object" * Remove pointless Javadocs * Fuse more statements into Stream API * Fix String.format errors * Remove unnecessary throws * Use enhanced for where possible * Remove unnecessary boxing and unboxing * Use try-with-resources where possible * Use diamond operator where possible * Remove unused imports * Replace anonymous type with lambda * Replace Collections.sort with List.sort * Simplify Map operations * Use Long.compare where possible * Use Collections.singletonList where possible * Arrays of wisdom of the ancients * Remove more unused imports * Remove redundant toString() call * Improve acceptance tests speed (jenkinsci#516) skip downloading jenkins plugins in cache when tests are skipped, keep the cache between builds Co-authored-by: Basil Crow <[email protected]> * Badge settings (jenkinsci#372) * Bump bytebuddy.version from 1.12.1 to 1.12.2 (jenkinsci#521) * Publish Parent POM during release (jenkinsci#522) While publishing the artifact the POM references the parent POM. However, the parent POM is not being published. This causes problems for people using Maven/Gradle to resolve the artifact - very common for people using `job-dsl-plugin` or `gradle-jpi-plugin`. This change publishes the parent POM so those users can get dependency resolution to work. Fixes jenkinsci#373 Fixes JENKINS-43171 * Miscellaneous code cleanup (jenkinsci#523) * Publish JAR in addition to HPI (jenkinsci#524) This allows other plugins that depend on this plugin to reference classes without having to first extract the HPI to get to the JAR. * Set classifier to empty for jar (jenkinsci#525) This should fix the build broken by jenkinsci#524 * Bump bom-2.289.x from 1013.vf8058992a042 to 1036.v9f5a1aba8fab Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 1013.vf8058992a042 to 1036.v9f5a1aba8fab. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.289.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Bump bytebuddy.version from 1.12.2 to 1.12.3 (jenkinsci#527) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump bom-2.289.x from 1036.v9f5a1aba8fab to 1055.v9637a690f734 (jenkinsci#533) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump bytebuddy.version from 1.12.3 to 1.12.5 (jenkinsci#531) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `bytebuddy.version` from 1.12.5 to 1.12.6 (jenkinsci#534) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump plugin from 4.31 to 4.32 (jenkinsci#535) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Basil Crow <[email protected]> * Bump `frontend-maven-plugin` from 1.12.0 to 1.12.1 (jenkinsci#537) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `plugin-management-cli` from 2.11.1 to 2.12.1 (jenkinsci#538) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `bom-2.289.x` from 1055.v9637a690f734 to 1075.v14bef33e5d7b (jenkinsci#539) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `plugin` from 4.32 to 4.33 (jenkinsci#541) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `bom-2.289.x` from 1075.v14bef33e5d7b to 1090.v0a_33df40457a_ (jenkinsci#540) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `plugin-management-cli` from 2.12.1 to 2.12.3 (jenkinsci#547) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `bytebuddy.version` from 1.12.6 to 1.12.7 (jenkinsci#546) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `badge` from 1.9 to 1.9.1 (jenkinsci#544) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `slf4j.version` from 1.7.32 to 1.7.33 (jenkinsci#545) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix acceptance tests (jenkinsci#548) fail the build if a test fails * Ignore annotation API updates * Ignore Enforcer warnings for annotation API (jenkinsci#550) * Bump `bom-2.289.x` from 1090.v0a_33df40457a_ to 1117.v62a_f6a_01de98 (jenkinsci#551) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `bom-2.289.x` from 1117.v62a_f6a_01de98 to 1135.va_4eeca_ea_21c1 (jenkinsci#556) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump SLF4J from 1.7.33 to 1.7.35 (jenkinsci#553) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump XStream from 1.4.18 to 1.4.19 (jenkinsci#555) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Guice from 5.0.1 to 5.1.0 (jenkinsci#557) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `ini` from 1.3.5 to 1.3.8 in `/build-monitor-plugin` (jenkinsci#558) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump bom-2.289.x from 1135.va_4eeca_ea_21c1 to 1148.v7261f385f859 (jenkinsci#560) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Serenity from 2.4.51 to 3.2.0 (jenkinsci#564) * Clean up POM (jenkinsci#566) * Integration with JUnit Realtime Test Reporter (jenkinsci#542) Add integration with the JUnit Realtime Test Reporter plugin. Display a progress bar based on the number of tests and the execution time, using the previous build's test results. * Replace deprecated `net.serenitybdd.screenplay.Action` with non-deprecated `net.serenitybdd.screenplay.Interaction` (jenkinsci#567) * Use lambda where possible (jenkinsci#568) * Bump plugin parent POM from 4.33 to 4.34 (jenkinsci#571) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Byte Buddy from 1.12.7 to 1.12.8 (jenkinsci#570) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump SLF4J from 1.7.35 to 1.7.36 (jenkinsci#572) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add default settings to Build Monitor Views (jenkinsci#573) * Bump plugin parent POM from 4.34 to 4.35 (jenkinsci#574) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump plugin BOM from 1148.v7261f385f859 to 1155.v77b_fd92a_26fc (jenkinsci#575) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump plugin parent POM from 4.35 to 4.37 (jenkinsci#576) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 2 to 3 (jenkinsci#577) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Guava from 31.0.1 to 31.1 (jenkinsci#578) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump plugin BOM from 1155.v77b_fd92a_26fc to 1181.v04b_21d4b_0d6c (jenkinsci#581) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump bom-2.303.x from 1181.v04b_21d4b_0d6c to 1198.v387c834fca_1a_ (jenkinsci#582) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump plugin parent POM from 4.37 to 4.38 (jenkinsci#583) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump bom-2.303.x from 1198.v387c834fca_1a_ to 1210.vcd41f6657f03 (jenkinsci#585) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Serenity from 3.2.0 to 3.2.1 (jenkinsci#584) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/cache from 2 to 3 (jenkinsci#586) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump plugin parent POM from 4.38 to 4.39 (jenkinsci#590) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Serenity from 3.2.1 to 3.2.3 (jenkinsci#589) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump bom-2.303.x from 1210.vcd41f6657f03 to 1246.va_b_50630c1d19 (jenkinsci#588) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `actions/setup-java` from 2 to 3 (jenkinsci#595) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Byte Buddy from 1.12.8 to 1.12.9 (jenkinsci#592) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump JaCoCo Maven Plugin from 0.8.7 to 0.8.8 (jenkinsci#593) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump `actions/upload-artifact` from 2 to 3 (jenkinsci#594) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump plugin parent POM from 4.39 to 4.40 (jenkinsci#591) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump bom-2.303.x from 1246.va_b_50630c1d19 to 1280.vd669827e38cd (jenkinsci#597) * Resolve merge issue * fix warnings * fix XPath selectors for BuildMonitorDashboard Co-authored-by: Basil Crow <[email protected]> Co-authored-by: Jan Molak <[email protected]> Co-authored-by: Tim Jacomb <[email protected]> Co-authored-by: Daniel Beland <[email protected]> Co-authored-by: Daniel Beland <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rahul Somasunderam <[email protected]> Co-authored-by: Rahul Somasunderam <[email protected]> Co-authored-by: Carlo Giorgetta <[email protected]>
|
@dcendents I would like to extend an open invitation for you to become a (co-)maintainer of this plugin along with Jan and I, if you are interested. You have been the most prolific contributor to this plugin, and it would be great to have you on board to keep this plugin healthy moving forward. |
|
Thanks @basil and @jan-molak , I'd be glad to join you and help maintain this plugin. Let me know what I need to do to make it official. |
|
@dcendents Now that this plugin is under the Jenkins project's umbrella, it is simply a matter of opening a PR to add yourself to https://github.com/jenkins-infra/repository-permissions-updater/blob/4956af1cf35db750bbbbf8b362b0adbbf63155e7/permissions/plugin-build-monitor-plugin.yml#L9-L10. |
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "rebase" of #425
Now using the view config page, any positive value can be set for font size and number of columns. (Which is a good thing as poeple did not always like the current limitations, who are we to say what looks better on their monitor).
To reflect that, I have also increased the sliders in the Settings panel, font size 0.1 to 5 (was 2), number of columns 1 to 20 (was 8). These are still arbitrary values but I did not want to change the slider so I had to set something that seems reasonable.
After this is merged we can close the following PRs and issues:
Fixes #425
Fixes #413
Fixes #409
Fixes #315
Fixes #227
Fixes #189
Fixes #119
Fixes #71