use custom DNS in the ath container to enable HAR recording #1331
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using the sslip.io DNS service in CI whilst keeping it for local debugging / test runs. the entry for JENKINS_LOCAL_HOSTNAME is added as a hosts for the docker container when running in CI so that we do not trly on DNS queries in the tests, but will still have a HAR when run locally in docker (unless the host is also added there)
timja
reviewed
Aug 14, 2023
| @@ -80,4 +80,4 @@ fi | |||
|
|
|||
| set -x | |||
|
|
|||
| BROWSER=$browser JENKINS_WAR=$war $MVN $extra_args "$@" | |||
| BROWSER=$browser JENKINS_LOCAL_HOSTNAME=jenkins.127.0.0.1.sslip.io JENKINS_WAR=$war $MVN $extra_args "$@" | |||
There was a problem hiding this comment.
we could do it a different way - not modify the files and just start docker with the environment variable and the host I guess.
That way consumers will be unaffected, (but they would not get HAR files unless they adapted their usage)
do you know of any more consumers than this https://github.com/search?q=org%3Ajenkinsci%20jenkins%2Fath&type=code shows the only other consumer of the container as the xvnc plugin - but that does not use |
jtnord
added a commit
to jtnord/jenkins
that referenced
this pull request
Aug 14, 2023
downstream of jenkinsci/acceptance-test-harness#1331 adds a host entry to avoid DNS lookups using the sslip.io DNS service.
|
not that I know of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a custom DNS so firefox does not bypass the proxy, whilst also configuring docker with a mapping for the address to avoid flakyness.
The code will still work without the
--add-hostif people are starting the test suite manually, however it will then rely on an external DNS service which may be flaky.