Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxarm64: enable rkmpp and rkrga for portable builds #403

Merged
merged 10 commits into from
Jul 24, 2024

Conversation

bjia56
Copy link
Contributor

@bjia56 bjia56 commented Jun 21, 2024

This PR enables rkmpp and rkrga for portable Linux arm64 builds of ffmpeg. Both libraries are built statically and linked into the resulting binary.

Changes

  • Enable static rkmpp and rkrga for Linux arm64 portable builds
  • Add patch to rkmpp to fix collisions with libvpx
  • Add patch to rkrga to enable static lib build
  • Modify rkrga lib lookup to use pkgconfig

Issues

None

builder/patches/rkmpp/0000-fix-vpx-collisions.patch Outdated Show resolved Hide resolved
builder/patches/rkrga/0000-build-static.patch Outdated Show resolved Hide resolved
builder/scripts.d/60-rkmpp.sh Outdated Show resolved Hide resolved
builder/scripts.d/60-rkrga.sh Outdated Show resolved Hide resolved
@nyanmisaka
Copy link
Member

60-rkmpp.sh -> 50-rkmpp.sh
60-rkrga.sh -> 50-rkrga.sh

50 or even lower should be enough, since they don't depend on libdrm or other libs.

@bjia56
Copy link
Contributor Author

bjia56 commented Jun 21, 2024

Comments addressed. I opened rockchip-linux/mpp#621 for the upstream fix - the patch has been kept in the PR for the time being, in case there are any blockers in upstreaming it.

@nyanmisaka nyanmisaka merged commit ffb3842 into jellyfin:jellyfin Jul 24, 2024
0 of 21 checks passed
@bjia56 bjia56 deleted the rockchip branch July 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants