Fix user image being too cropped in #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, for some reason I'm only able to replicate the bug in 0.16 betas and on master. On the .15 release the image is loaded correctly with no issues. |
|
We switched the image library from Glide to Coil (#2889) for 0.16 so this is likely a regression from that change. |
|
I noticed this also in the 0.16 branch fwiw |
nielsvanvelzen
requested changes
Sep 9, 2023
|
Issue seems to be caused by coil-kt/coil#1505, changing the placeholder to be square should be a good fix to workaround the issue. |
nielsvanvelzen
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
On first open of the user select menu the transition between the placeholder and the user image forced the image to use the dimensions of the placeholder. This resulted in the image being far too cropped in.
Before
After
This is kinda a hack as I simply converted the placeholder image into a square, but it works and I'm not sure what else could be done.