Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move useExternalPlayer and getPlaybackActivityClass functions to new PlaybackLauncher interface #1064

Merged
merged 3 commits into from
Aug 8, 2021

Conversation

nielsvanvelzen
Copy link
Member

This change is to make sure development for the new playback code can happen in the master branch while still being able to release updates with the old code. It does this by adding a new interface "PlaybackLauncher" that is used when launching the playback activity and a toggle for which implementation to use.

When the initial playback module is added this will launch an activity that reads the data from the current playback code (item to play etc.) and converts it to the new playback module format before launching the new playback module activity. This is a bit hacky but good enough for development.

The implementation toggle only works on debug builds of the app and will never show up on releases.

Changes

  • Move useExternalPlayer and getPlaybackActivityClass functions to new PlaybackLauncher interface
  • Implement PlaybackLauncher interface with old code
  • "Implement" PlaybackLauncher interface for new playback code
  • Add toggle to enable new playback module

Issues

Part of #1057

@nielsvanvelzen nielsvanvelzen mentioned this pull request Aug 2, 2021
35 tasks
@nielsvanvelzen nielsvanvelzen removed the request for review from thornbill August 8, 2021 17:04
@nielsvanvelzen nielsvanvelzen merged commit fe75e4b into jellyfin:master Aug 8, 2021
@nielsvanvelzen nielsvanvelzen deleted the playback-launcher branch August 8, 2021 17:05
@nielsvanvelzen nielsvanvelzen added playback Issue related to media playback refactor Improvements to code realiability, readability and quality labels Oct 29, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playback Issue related to media playback refactor Improvements to code realiability, readability and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants