Move useExternalPlayer and getPlaybackActivityClass functions to new PlaybackLauncher interface #1064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to make sure development for the new playback code can happen in the master branch while still being able to release updates with the old code. It does this by adding a new interface "PlaybackLauncher" that is used when launching the playback activity and a toggle for which implementation to use.
When the initial playback module is added this will launch an activity that reads the data from the current playback code (item to play etc.) and converts it to the new playback module format before launching the new playback module activity. This is a bit hacky but good enough for development.
The implementation toggle only works on debug builds of the app and will never show up on releases.
Changes
Issues
Part of #1057