-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Absolute permalinks break paginator when permalink is specified for index file #5 #23
Open
ducktyper
wants to merge
4
commits into
jekyll:master
Choose a base branch
from
ducktyper:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dcf6bc3
Fix absoulte permalink in index file is set to pagenated pages
ducktyper 485dc8a
Fix paginator looks for index file based on permalink if set
ducktyper ae20d87
Extract paginated page factory
ducktyper 0bbdd80
Use page.relative_path to build paginated page
ducktyper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
require 'spec_helper' | ||
|
||
RSpec.describe(Jekyll::Paginate::Pagination) do | ||
|
||
context "with absoulte permalink in index file" do | ||
before(:each) do | ||
@original_index_string = File.read(File.join(source_dir, 'index.html')) | ||
end | ||
after(:each) do | ||
File.open(File.join(source_dir, 'index.html'), 'w') { |f| f.write(@original_index_string) } | ||
end | ||
|
||
def rewrite_index(frontmatter_string) | ||
File.open(File.join(source_dir, 'index.html'), 'w') { |f| f.write("---\n#{frontmatter_string}\n---\nbody") } | ||
end | ||
|
||
let(:site) { build_site } | ||
|
||
it "paginated pages should not use absoulte permalink from index file" do | ||
rewrite_index("permalink: /") | ||
expect(site.pages.select {|page| page.url == "/"}.length).to eql(1) | ||
end | ||
|
||
it "paginated pages should be generated from index file given parmalink not matched to source" do | ||
rewrite_index("permalink: /posts/") | ||
site | ||
expect(File.read(File.join(dest_dir('page2'), 'index.html'))).to eql("body") | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
page.path
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried with page.path but test was failed since this includes filename.
File.dirname(page.path) seems to be another solution clearer than page.url_placeholders[:path]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try
page.relative_path
then 😄 There was a liquid inconsistency that this will bump into.