-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified functions #138
Open
CxRes
wants to merge
6
commits into
jeff-zucker:master
Choose a base branch
from
CxRes:unified-functions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Unified functions #138
Commits on Apr 10, 2020
-
Added moveFile and moveFolder functions
In preparation for unified functions, added `moveFile` and `moveFolder` functions: + This will make the API for move consistent with copy and delete. + It will allow us to create a unified move function independent of existing functionality.
Configuration menu - View commit details
-
Copy full SHA for 5836b70 - Browse repository at this point
Copy the full SHA 5836b70View commit details
Commits on Apr 11, 2020
-
The new `copy` function unifies `copyFile` and `copyFolder`. It determines whether the source is a file or folder from the server response (without the need for an extra network request) instead of the trailing slash on provided source url.
Configuration menu - View commit details
-
Copy full SHA for cd83ba3 - Browse repository at this point
Copy the full SHA cd83ba3View commit details -
Reuses prior GET and PUT responses to get links for copying. This saves unnecessary extra HEAD calls being made to fetch links. Logic for copying links remains unchanged.
Configuration menu - View commit details
-
Copy full SHA for fd67dbf - Browse repository at this point
Copy the full SHA fd67dbfView commit details -
Improved Input Error Handling for Copy
The error handling for inputs is placed in its own function, which tests: + if inputs are strings + if source and destination are not the same + if the source is not a parent of the destination
Configuration menu - View commit details
-
Copy full SHA for 49ae3bc - Browse repository at this point
Copy the full SHA 49ae3bcView commit details
Commits on Apr 12, 2020
-
The new `remove` function unifies both `deleteFile` and `deleteFolder`. (It can't be called `delete`, which is already reserved by the low level API) It determines whether the source is a file or folder from the server response (HEAD call is reused in case of file deletion) instead of the presence of a trailing slash on provided source url.
Configuration menu - View commit details
-
Copy full SHA for b14fabc - Browse repository at this point
Copy the full SHA b14fabcView commit details -
The new `move` function that builds upon the unified `copy` and `remove` functions It avoids the unnecessary duplication of work that resulted from running copy and delete separately.
Configuration menu - View commit details
-
Copy full SHA for 5bde7f8 - Browse repository at this point
Copy the full SHA 5bde7f8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.