This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prelude: header files are a total mess with so much history burden.
Thanks to the ingenious
#include_next
hack widely used inside STL (c.f. wrapper headers), the order of search paths does matter, unfortunately. The most important rule for C++ projects is: always include C++ STL headers before system/C headers, as C++ STL will often#include_next
the underlying C APIs, wrap them, undefine the names from the C headers, and finally redefine the names to the wrappers, in order to achieve things like precise overloads.If we switch around the order, things will break miserably, which could easily happen right now if anyone (or some tool) puts
-isystem /usr/include
in.color_coded
. Here's a simple test case:In an empty folder,
test.cpp
:.color_coded
:(C++ headers will be appended to the search path by
defautlts.hpp
.)And then you will see errors similar to those in #139 and #130 . In fact, I speculate this is the root cause of those two issues. Yet I don't have a Mac to be sure.