Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved development flow #70

Merged
merged 3 commits into from
Apr 10, 2015
Merged

Improved development flow #70

merged 3 commits into from
Apr 10, 2015

Conversation

jbovenschen
Copy link
Collaborator

A proposal / proof of concept for a new development flow.

  • Uses webpack instead of browserify
  • Uses UMD (So it will be compatible with most of the popular script loaders)
  • While developing the content of the dist folder will not be changed
  • Code linting while developing

jbovenschen added 2 commits April 9, 2015 22:44
- Changed build tool to webpack

- Other improvements:
    - Make use of UMD (So it will be full compatible with the most
popular script loaders)
    - Source code in dist folder will not be overwritten when developing
And added opening default browser when using gulp test
},

module: {
preLoaders: [{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab spacing consistency please :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a pull request to fast 👎.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries - not a huge deal. Thanks for fixing so quickly.

@jdan
Copy link
Owner

jdan commented Apr 9, 2015

Really great stuff, thank you so much!

Real quick - could you explain the benefits of webpack over browserify? And what's UMD and where can I see those changes in this diff?

And one more - how does the dev-server work?

@jbovenschen
Copy link
Collaborator Author

No thanks! Just did it because i like to work with webpack and use it with a babel loader like i mentioned in #71 never used that with browserify myself.

Webpack once setup is easier to use and more plug and play (my opinion) and it has the possibility to use the ES6 module transpiler. It also does not regenerate the whole bundle only the chunks which are changed (Improvement when developing).

Here is some more info about UMD (https://github.com/umdjs/umd)
This is handled by webpack with defining the libraryTarget in the config.

The webpack dev server just serves all content in the test folder. And add the current bundles to it's assets. (Like beefy did).


return es.concat(uncompressed, minified);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, cool pattern!

@jdan
Copy link
Owner

jdan commented Apr 10, 2015

Just checked it out, everything looks good.

Super impressive stuff, thanks again for doing this!

jdan added a commit that referenced this pull request Apr 10, 2015
@jdan jdan merged commit 30ef913 into jdan:master Apr 10, 2015
@jdan
Copy link
Owner

jdan commented Apr 10, 2015

@jbovenschen I've added you as a collaborator on this repo. Feel free to close issues, merge PRs, etc. as you see fit. For any big changes I'd prefer if we continued to open PRs for each other, but I'll let you make that call :)

No pressure or anything, just figured I'd open up the gates after seeing your enthusiasm for this project. Looking forward to working with you!

@jbovenschen
Copy link
Collaborator Author

Great! Thanks!

@jbovenschen
Copy link
Collaborator Author

It is in the webpack config. You will be notified when there is an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants