-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved development flow #70
Conversation
- Changed build tool to webpack - Other improvements: - Make use of UMD (So it will be full compatible with the most popular script loaders) - Source code in dist folder will not be overwritten when developing
And added opening default browser when using gulp test
}, | ||
|
||
module: { | ||
preLoaders: [{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab spacing consistency please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a pull request to fast 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries - not a huge deal. Thanks for fixing so quickly.
Really great stuff, thank you so much! Real quick - could you explain the benefits of webpack over browserify? And what's UMD and where can I see those changes in this diff? And one more - how does the dev-server work? |
No thanks! Just did it because i like to work with webpack and use it with a babel loader like i mentioned in #71 never used that with browserify myself. Webpack once setup is easier to use and more plug and play (my opinion) and it has the possibility to use the ES6 module transpiler. It also does not regenerate the whole bundle only the chunks which are changed (Improvement when developing). Here is some more info about UMD (https://github.com/umdjs/umd) The webpack dev server just serves all content in the test folder. And add the current bundles to it's assets. (Like beefy did). |
|
||
return es.concat(uncompressed, minified); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, cool pattern!
Just checked it out, everything looks good. Super impressive stuff, thanks again for doing this! |
@jbovenschen I've added you as a collaborator on this repo. Feel free to close issues, merge PRs, etc. as you see fit. For any big changes I'd prefer if we continued to open PRs for each other, but I'll let you make that call :) No pressure or anything, just figured I'd open up the gates after seeing your enthusiasm for this project. Looking forward to working with you! |
Great! Thanks! |
It is in the webpack config. You will be notified when there is an issue. |
A proposal / proof of concept for a new development flow.