Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Work with new o1 models #62

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jcrodriguez1989
Copy link
Owner

No description provided.

Copy link

I have reviewed the GitHub PR diff provided. Here are the issues I have identified:

  1. In the file .github/workflows/code-review-gpt.yaml:

    • Line 33: The variable assignment GITHUB_BASE_REF <- paste0("origin/", Sys.getenv("GITHUB_BASE_REF")) should be corrected to use origin/develop instead of origin/feature.jcr.work_with_new_models.
  2. In the file DESCRIPTION:

    • Lines 24-26: Unnecessary changes to importing xfun package were made that should be reverted.
  3. In the file NAMESPACE:

    • Lines 8-9: Unnecessary changes in exporting and importing functions were made and should be reverted.
  4. In the file R/ask_chatgpt.R:

    • Lines 6-9: The removal of the parameter images in the function definition should be reverted.
    • Lines 17-18: The reference to the parameter images in the function implementation should be restored.
  5. In the file R/chatgpt-package.R:

    • Lines 9-11: Additional lines regarding GPT Models should be maintained for the system parameter handling.
  6. In the fileR/reset_chat_session.R:

    • Lines 15-17: The condition for assigning a default session should be updated to check against the OPENAI_MODEL environment variable and the systemless_models.

R/get_chat_session.R and R/gpt_get_completions.R:

  • Similar to other files, the check for systemless_models should be added to appropriate places where system roles are handled.

R/parse_response.R:

  • Lines 12-14: The condition for verbosity should be updated to check if OPENAI_VERBOSE is greater than 1.

man/ask_chatgpt.Rd, man/build_prompt_content.Rd, and man/generate_image.Rd:

  • The removal of documentation for the images parameter should be reverted.

Please review these points and make the necessary adjustments in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant