Fix: display all values in playback card #1076

jcorporation · Jul 29, 2023 · 53ebb92 · 53ebb92
1 parent 7da9973
commit 53ebb92
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ This is a small bug fix release.
 - Fix: set translated title for navbar icons
 - Fix: jukebox list context menu actions
 - Fix: calculate correct myMPDuri for IPv6 [::]
+- Fix: display all values in playback card #1076
 
 ***
 

diff --git a/htdocs/js/Playback.js b/htdocs/js/Playback.js
@@ -216,9 +216,9 @@ function parseCurrentSong(obj) {
  */
 function setPlaybackCardTags(songObj) {
     if (songObj.webradio === undefined) {
+        elHideId('cardPlaybackWebradio');
+        elShowId('cardPlaybackTags');
         for (const col of settings.colsPlayback) {
-            elHideId('cardPlaybackWebradio');
-            elShowId('cardPlaybackTags');
             const c = document.getElementById('current' + col);
             if (c === null) {
                 continue;
@@ -236,14 +236,13 @@ function setPlaybackCardTags(songObj) {
                     if (value === undefined) {
                         value = '-';
                     }
+                    elReplaceChild(c.querySelector('p'), printValue(col, value));
                     if (checkTagValue(value, '-') === true ||
                         settings.tagListBrowse.includes(col) === false)
                     {
-                        elClear(c.querySelector('p'));
                         c.querySelector('p').classList.remove('clickable');
                     }
                     else {
-                        elReplaceChild(c.querySelector('p'), printValue(col, value));
                         c.querySelector('p').classList.add('clickable');
                     }
                     setData(c, 'name', value);