Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/build.yml: Use debug std C++ library on Ubuntu #1247

Merged
merged 2 commits into from
Nov 27, 2023
Merged

workflows/build.yml: Use debug std C++ library on Ubuntu #1247

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b506b4
workflows/build.yml: Use debug std C++ library on Ubuntu
rico-chet Nov 26, 2023
a34db04
README.md: Describe building with debug libstdc++ mode
rico-chet Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
${{format(matrix.generator != 'Default Generator' && '-G "{0}"' || '', matrix.generator)}}
CMAKE_INSTALL_PREFIX: "${{ github.workspace }}/install-prefix"
CMAKE_BUILD_TYPE: Debug
CMAKE_CXX_FLAGS_DEBUG: ${{ matrix.googletest == 'build' && '-g -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC' || '-g' }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you put the googletest == build clause here? Does the system googletest fail with these flags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 'system' failed to build, just 'build' worked.

I didn't dig deeper, but it's a common effect in the debug mode of the GNU standard C++ library that it can only be mixed with non-debug binaries when those do not exchange data with the debug-generated code in e.g. ˋstd::ˋ containers or smart pointers. I thus assumed that the system-provided googletest (which is obviously non-debug) doesn't mix with the debug structures, by design. So I excluded these variants from being built in the debug mode.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good. Can you add a comment explaining this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just added an entry to the README. (did it during work time, so posting with my work account)

runs-on: ${{ matrix.os }}
steps:

Expand All @@ -57,6 +58,7 @@ jobs:
-D CMAKE_CXX_STANDARD=${{ matrix.cxx_standard }} \
-D CMAKE_INSTALL_PREFIX="${{ env.CMAKE_INSTALL_PREFIX }}" \
-D CMAKE_BUILD_TYPE=${{ env.CMAKE_BUILD_TYPE }} \
-D CMAKE_CXX_FLAGS_DEBUG="${{ env.CMAKE_CXX_FLAGS_DEBUG }}" \
-D YAML_BUILD_SHARED_LIBS=${{ env.YAML_BUILD_SHARED_LIBS }} \
-D YAML_USE_SYSTEM_GTEST=${{ env.YAML_USE_SYSTEM_GTEST }} \
-D YAML_CPP_BUILD_TESTS=ON
Expand Down
Loading