Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate prettier-plugin-toml for pre-commit hooks #2053

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −6
Open

Activate prettier-plugin-toml for pre-commit hooks #2053

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6e7fb7
Activate prettier-plugin-toml for pre-commit hooks
Feb 13, 2024
6b5de83
Ignore short multiline entry
Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .prettierrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ overrides:
- files: "CHANGELOG.md"
options:
proseWrap: always
plugins:
- "prettier-plugin-toml"
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ dynamic = ["dependencies", "optional-dependencies"]
[tool.setuptools.dynamic]
dependencies = { file = ["requirements.in"] }
optional-dependencies.test = { file = ["requirements-test.txt"] }

```

If you have a Django application that is packaged using `Hatch`, and you
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ dependencies = [
"tomli; python_version < '3.11'",
# indirect dependencies
"setuptools", # typically needed when pip-tools invokes setup.py
"wheel", # pip plugin needed by pip-tools
"wheel", # pip plugin needed by pip-tools

]

Expand Down
6 changes: 1 addition & 5 deletions tests/test_data/packages/small_fake_with_build_deps/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
[build-system]
requires = [
"setuptools==68.1.2",
"wheel==0.41.1",
"fake_static_build_dep"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if having a trailing comma after the last item here would make the formatter to the right thing and keep the list. Worth checking...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, but that would be lovely.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a Feature Request in the plugin project.

]
requires = ["setuptools==68.1.2", "wheel==0.41.1", "fake_static_build_dep"]
build-backend = "backend"
backend-path = ["backend"]