Fix config file search and inclusion in header #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysle
added
bug
chrysle
force-pushed
the
fix-config-file-search-path
branch
from
685bcba to
0385403
Compare
chrysle
force-pushed
the
fix-config-file-search-path
branch
from
0385403 to
db7b044
Compare
for more information, see https://pre-commit.ci
chrysle
force-pushed
the
fix-config-file-search-path
branch
from
c1474fd to
cbc8f01
Compare
webknjaz
reviewed
Feb 14, 2024
| @@ -630,7 +630,7 @@ def select_config_file(src_files: tuple[str, ...]) -> Path | None: | |||
| # NOTE: input. | |||
| working_directory = Path.cwd() | |||
| src_files_as_paths = ( | |||
| (working_directory / src_file).resolve() for src_file in src_files or (".",) | |||
| (working_directory / src_file).resolve() for src_file in src_files + (".",) | |||
There was a problem hiding this comment.
Could you explain this? Obviously, there's some unspecified side effect in external logic, but I don't get it.
There was a problem hiding this comment.
This adds the current working directory to the search path for source files as well, as proposed in the linked issue.
webknjaz
reviewed
Feb 14, 2024
| @@ -245,6 +245,7 @@ def _get_default_option(option_name: str) -> Any: | |||
| src_files = click.argument( | |||
| "src_files", | |||
| nargs=-1, | |||
| is_eager=True, | |||
There was a problem hiding this comment.
See #1902 (comment). Making only src_files eager doesn't work though, as it won't pick up the config if not specified, then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled over this issue again, so I thought I might as well fix it.
Closes #1902
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.