Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/adding template filter for switch flag sample usable for if statements #531

Closed
wants to merge 19 commits into from
Closed

Feature/adding template filter for switch flag sample usable for if statements #531

wants to merge 19 commits into from

Conversation

MatthewEthanTam
Copy link

This PR addresses the issue #510

ulgens
ulgens requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@ulgens ulgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your changes doesn't affect any of the localization strings, no need to update the .po files.

Also, please try to rebase instead of merging in. It helps to keep the PR clean.

MatthewEthanTam and others added 11 commits November 18, 2024 07:40
@MatthewEthanTam
Revert "Merge branch 'master' into feature/adding-template-filter-for…
3f3adb5 
…-switch-flag-sample-usable-for-if-statements"

This reverts commit 2d137d5, reversing
changes made to fded0ae.
@MatthewEthanTam
Revert "running ./run.sh makemessages and compliemessages"
9fd2ba4 
This reverts commit 0a67973.
@cclauss @MatthewEthanTam
Use ruff to lint Python code (jazzband#518)
60c3dc1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cda0f97 
for more information, see https://pre-commit.ci
@MatthewEthanTam
Revert "Use ruff to lint Python code (jazzband#518)"
87bed70 
This reverts commit 60c3dc1.
@cclauss @MatthewEthanTam
Use ruff to lint Python code (jazzband#518)
dfae8be
@MatthewEthanTam
Revert "Use ruff to lint Python code (jazzband#518)"
97db292 
This reverts commit dfae8be.
@cclauss @MatthewEthanTam
Use ruff to lint Python code (jazzband#518)
70a5751
@MatthewEthanTam
Revert "Use ruff to lint Python code (jazzband#518)"
62a20f8 
This reverts commit 70a5751.
@MatthewEthanTam
running ./run.sh makemessages and compliemessages
80b1d5d
@cclauss @MatthewEthanTam
Use ruff to lint Python code (jazzband#518)
bacf2a1
@MatthewEthanTam
Copy link
Author

Closing PR as too many reverts #532 will address the following

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgens ulgens ulgens requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthewEthanTam @ulgens @cclauss