Get django-voting working with Django 1.11 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late.resolve_variable)
seirl
reviewed
Apr 6, 2017
| user = template.resolve_variable(self.user, context) | ||
| objects = template.resolve_variable(self.objects, context) | ||
| user = template.Variable(self.user).resolve(context) | ||
| objects = template.Variable(self.object).resolve(context) |
There was a problem hiding this comment.
i think i was working with a pre-release version of django1.11 if that's the case ...
There was a problem hiding this comment.
It's probably just a typo, all the other ones are correct but for this one you forgot to add the s when you changed this code.
There was a problem hiding this comment.
Thanks - i've been away, just pushed this update to my fork.
|
What's the status on this? |
|
Project update: Move to Jazzband, or retire? #13 |
|
Support for 2.2, 3.0 and 3.1 is now in 1.0. Please reopen another PR if you're interested in contributing the other changes in this PR that are unrelated to compatibility. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get django-voting working with Django 1.11 (which has deprecated template.resolve_variable).
NB - could do with a try / except to maintain compatibility with earlier django versions.