Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history listing of deleted objects #195

Merged
merged 4 commits into from
Oct 24, 2015
Merged

Conversation

macro1
Copy link
Collaborator

@macro1 macro1 commented Oct 10, 2015

It has been a really long time since I looked at this, and it turned out easier than I thought. Of course, the main admin page for the object will still give you a 404, but if you navigate directly to the history page you'll be able to view the list of changes after an object has been deleted.

resolves #72

@KevinGrahamFoster
Copy link
Contributor

Very cool. Thanks!

macro1 added a commit that referenced this pull request Oct 24, 2015
@macro1 macro1 merged commit 089c5d4 into master Oct 24, 2015
@macro1 macro1 deleted the allow-deleted-history-page branch October 24, 2015 05:08
@marcgibbons
Copy link

@macro1 Any thoughts on how best to access the list of deleted objects from the admin?

@macro1
Copy link
Collaborator Author

macro1 commented Dec 5, 2015

@marcgibbons: The change above was to allow the page listing all changes to an instance (all the entries in the history table) to be visible even after the object was deleted. We don't currently offer a way to find back deleted instances easily in the admin. (So the list of changes are available, but only if you know the id of the deleted instance already.)

As always, if you find this is something useful to you, feel free to make a pull request and we can see what it would take to get it offered as a feature. If you don't feel up to the task, you can open an issue as well, describing what you're looking for.

Edit: I think I can see where some confusion may have arisen. #72 requested a list of deleted instances as well as the ability to see those histories. I only accomplished the second part, so I reopened the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View deleted instances from admin page
3 participants