Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history form renders incorrect if readonly (and pre-commit-ci) #1410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fetzig
Copy link

@fetzig fetzig commented Oct 14, 2024

Rendering behaviour of history change_form isn't as expected if has_change_permission == False.

UPDATE: Also fixes the pre-commit-ci job by upgrading to python 3.9.

Description

django Admin renders a "form" full of readonly_fields in this case:

@admin.register(Foo)
class FooAdmin(SimpleHistoryAdmin):
    # ...

    def has_change_permission(self, request, obj=None):
        return False

Instead of rendering like the original change_form of Foo (just readonly fields), it renders form fields (input tags). But no submit buttons.

djangos ModelAdmin adds all fields to ModelAdmin.readonly_fields.

This behaviour has been copied ModelAdmin._changeform_view to SimpleHIstoryAdmin.history_form_view.

Related Issue

An Issue for this already exists: #1362

Motivation and Context

Getting SimpleHistoryModel to act as expected, which is to be consistent with djangos ModelAdmin.

How Has This Been Tested?

Comparing of SimpleHistoryModel behaviour with corresponding ModelAdmin and default django-simple-history settings.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

fetzig and others added 3 commits October 14, 2024 23:36

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell
…s_change_permission returns False

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell
for more information, see https://pre-commit.ci
@fetzig fetzig changed the title fixes #1362: incorrect rendering of history change form if has_change_permission == False fixes #1362: incorrect rendering of history change form (and pre-commit-ci) Oct 14, 2024
@fetzig fetzig changed the title fixes #1362: incorrect rendering of history change form (and pre-commit-ci) fixes #1362: incorrect readonly version history change form (and pre-commit-ci) Oct 14, 2024
@fetzig fetzig changed the title fixes #1362: incorrect readonly version history change form (and pre-commit-ci) fixes #1362: incorrect readonly version of history form (and pre-commit-ci) Oct 14, 2024
@fetzig fetzig changed the title fixes #1362: incorrect readonly version of history form (and pre-commit-ci) fixes #1362: history form renders incorrect if readonly (and pre-commit-ci) Oct 14, 2024
@fetzig fetzig changed the title fixes #1362: history form renders incorrect if readonly (and pre-commit-ci) history form renders incorrect if readonly (and pre-commit-ci) Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant