history form renders incorrect if readonly (and pre-commit-ci) #1410
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering behaviour of history change_form isn't as expected if
has_change_permission == False
.Description
django Admin renders a "form" full of readonly_fields in this case:
Instead of rendering like the original change_form of
Foo
(just readonly fields), it renders form fields (input tags). But no submit buttons.djangos
ModelAdmin
adds all fields toModelAdmin.readonly_fields
.This behaviour has been copied
ModelAdmin._changeform_view
toSimpleHIstoryAdmin.history_form_view
.Related Issue
An Issue for this already exists: #1362
Motivation and Context
Getting SimpleHistoryModel to act as expected, which is to be consistent with djangos ModelAdmin.
How Has This Been Tested?
Comparing of SimpleHistoryModel behaviour with corresponding ModelAdmin and default django-simple-history settings.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst