Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Django 2.0 execute_wrapper() #631

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Use Django 2.0 execute_wrapper() #631

wants to merge 3 commits into from

Conversation

SebCorbin
Copy link
Contributor

No description provided.

@SebCorbin SebCorbin linked an issue Nov 20, 2022 that may be closed by this pull request
Consider using Django 2.0 execute_wrapper() #214
Open
@SebCorbin SebCorbin force-pushed the 214-consider-using-django-20-execute_wrapper branch from 1b76012 to 23917b8 Compare November 20, 2022 18:22
@SebCorbin SebCorbin requested a review from a team November 20, 2022 18:22
@codecov
Copy link

codecov bot commented Nov 20, 2022 •
edited
Loading

Codecov Report

Merging #631 (1d0d131) into master (5677fa8) will increase coverage by 0.43%.
The diff coverage is 95.55%.

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
+ Coverage   86.33%   86.77%   +0.43%     
==========================================
  Files          52       52              
  Lines        2093     2094       +1     
==========================================
+ Hits         1807     1817      +10     
+ Misses        286      277       -9
Impacted Files Coverage Δ
silk/sql.py 92.53% <94.73%> (+13.74%) ⬆️
silk/apps.py 100.00% <100.00%> (ø)
silk/middleware.py 88.77% <100.00%> (-0.55%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SebCorbin SebCorbin force-pushed the 214-consider-using-django-20-execute_wrapper branch from d8ebb11 to 9c2e38a Compare November 20, 2022 19:25
@ulgens
Copy link
Member

ulgens commented Nov 20, 2022

@SebCorbin Can you please give some details about this PR and its purpose? Thank you.

@SebCorbin
Copy link
Contributor Author

SebCorbin commented Nov 20, 2022 •
edited
Loading

@ulgens yes, see the related issue and last comment #214 (comment)

@SebCorbin SebCorbin force-pushed the 214-consider-using-django-20-execute_wrapper branch from 9c2e38a to c186f40 Compare November 20, 2022 22:43
@SebCorbin SebCorbin mentioned this pull request Nov 21, 2022
Open
@SebCorbin
Copy link
Contributor Author

After few days of real-world testing, the ready() method is not development-proof with the runserver command. I'll update this PR to switch to classic context manager on the middleware.

@SebCorbin SebCorbin marked this pull request as draft December 14, 2022 09:42
@SebCorbin SebCorbin self-assigned this Jan 9, 2023
@SebCorbin
Copy link
Contributor Author

Another option: rely on connection_created signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SebCorbin SebCorbin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using Django 2.0 execute_wrapper()
2 participants
@SebCorbin @ulgens