Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parentadmin.py #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update parentadmin.py #580

wants to merge 1 commit into from

Conversation

TarunvirBains
Copy link

fix parent admin form not behaving like an admin form (eg log out button context missing)

@TarunvirBains
Update parentadmin.py
1d62780 
fix parent admin form not behaving like an admin form (eg log out button context missing)
@j-antunes
Copy link
Contributor

Hi! Thanks for opening this PR. Could you please elaborate a bit more? What was the issue you where seeing? Is there any unit test you could add?

Thank you!

@AdamDonna
Copy link
Contributor

@TarunvirBains

  1. Please update the description of this PR to give a reviewer enough context to make an educated review
  2. Please add unit tests to confirm the behaviour doesn't introduce regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TarunvirBains @j-antunes @AdamDonna