Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deepcopy of the Q object #543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion polymorphic/query_translate.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,28 @@ def tree_node_correct_field_specs(my_model, node):
return potential_q_object


def _deepcopy_q_object(q):
"""
Make a deepcopy of a Q-object.
"""
def _copy_child(child):
if isinstance(child, tuple):
return child # tuples are immutable, no need to make a copy.
elif isinstance(child, Q):
return _deepcopy_q_object(child)
else:
raise RuntimeError("Unknown child type: %s", type(child))

children = [_copy_child(c) for c in q.children]

if hasattr(q, 'copy'): # Django 4.2+
obj = q.copy()
obj.children = children
else:
obj = Q(*children, _connector=q.connector, _negated=q.negated)
return obj


def translate_polymorphic_filter_definitions_in_args(queryset_model, args, using=DEFAULT_DB_ALIAS):
"""
Translate the non-keyword argument list for PolymorphicQuerySet.filter()
Expand All @@ -93,7 +115,7 @@ def translate_polymorphic_filter_definitions_in_args(queryset_model, args, using
Returns: modified Q objects
"""
return [
translate_polymorphic_Q_object(queryset_model, copy.deepcopy(q), using=using) for q in args
translate_polymorphic_Q_object(queryset_model, _deepcopy_q_object(q), using=using) for q in args
]


Expand Down