Skip to content

Commit

Permalink
Replace a deepcopy of the Q object custom deep copy
Browse files Browse the repository at this point in the history
  • Loading branch information
rrauenza committed May 11, 2023
1 parent bd5faf0 commit 8199c3d
Showing 1 changed file with 23 additions and 1 deletion.
24 changes: 23 additions & 1 deletion polymorphic/query_translate.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,28 @@ def tree_node_correct_field_specs(my_model, node):
return potential_q_object


def _deepcopy_q_object(q):
"""
Make a deepcopy of a Q-object.
"""
def _copy_child(child):
if isinstance(child, tuple):
return child # tuples are immutable, no need to make a copy.
elif isinstance(child, Q):
return _deepcopy_q_object(child)
else:
raise RuntimeError("Unknown child type: %s", type(child))

children = [_copy_child(c) for c in q.children]

if hasattr(q, 'copy'): # Django 4.2+
obj = q.copy()
obj.children = children
else:
obj = Q(*children, _connector=q.connector, _negated=q.negated)
return obj


def translate_polymorphic_filter_definitions_in_args(queryset_model, args, using=DEFAULT_DB_ALIAS):
"""
Translate the non-keyword argument list for PolymorphicQuerySet.filter()
Expand All @@ -93,7 +115,7 @@ def translate_polymorphic_filter_definitions_in_args(queryset_model, args, using
Returns: modified Q objects
"""
return [
translate_polymorphic_Q_object(queryset_model, copy.deepcopy(q), using=using) for q in args
translate_polymorphic_Q_object(queryset_model, _deepcopy_q_object(q), using=using) for q in args
]


Expand Down

0 comments on commit 8199c3d

Please sign in to comment.