Don't create temporary files #741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
314eter
force-pushed
the
compiler-pipe-stdout
branch
from
4785aa3 to
d9ea2f5
Compare
314eter
force-pushed
the
compiler-pipe-stdout
branch
from
d9ea2f5 to
848a80c
Compare
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
- Coverage 81.41% 81.33% -0.08%
==========================================
Files 33 33
Lines 1119 1109 -10
==========================================
- Hits 911 902 -9
+ Misses 208 207 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #694 the less compiler runs in the source directory, and creates a temporary file to save stdout. In our setup, the source directory is not writable, so this doesn't work.
I updated the
SubProcessCompilerto avoid creating temporary files.