Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.1: fix for migration error on upgrade to 3.0.0 #1491

Merged
merged 5 commits into from
Sep 7, 2024

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented Sep 6, 2024

Fixes #1489, #1490

Description of the Change

Add a forward migration that causes a token_checksum to be added to existing migrated tokens.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell
…tokens

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell
…r the forward migration of existing tokens

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell
… will hopefully sort things out.
@n2ygk n2ygk marked this pull request as ready for review September 6, 2024 21:12
@n2ygk n2ygk requested a review from a team September 6, 2024 21:13
@n2ygk n2ygk added this to the Release 3.0.1 milestone Sep 6, 2024

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell

Verified

This commit was signed with the committer’s verified signature.
n2ygk Alan Crosswell
@n2ygk n2ygk changed the title add a forward migration function that computes checksum for existing tokens 3.0.1: fix for migration error on upgrade to 3.0.0 Sep 7, 2024
@n2ygk n2ygk requested review from dulmandakh and dopry September 7, 2024 11:31
Copy link
Contributor

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't so any functional testing, but it looks good from a code review perspective.

@n2ygk
Copy link
Member Author

n2ygk commented Sep 7, 2024

I can't think of a good way to write tests for migration cases like this.

@n2ygk n2ygk merged commit 1d19e54 into jazzband:master Sep 7, 2024
19 checks passed
@n2ygk n2ygk deleted the bug/1490/token_checksum branch September 7, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.0.0 custom model migration non-unique error
2 participants