Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated model manager. #480

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

craiga
Copy link
Contributor

@craiga craiga commented Apr 5, 2021

Problem

Fixes #364 by not using SoftDeletableManager as the default manager for SoftDeletableModel.

Solution

Explain the solution that has been implemented, and what has been changed.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #480 (afe4ac9) into master (9d0dfc3) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   94.57%   94.52%   -0.06%     
==========================================
  Files           6        6              
  Lines         756      749       -7     
==========================================
- Hits          715      708       -7     
  Misses         41       41              
Impacted Files Coverage Δ
model_utils/managers.py 98.04% <ø> (-0.06%) ⬇️
model_utils/models.py 98.91% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0dfc3...afe4ac9. Read the comment docs.

@tadamcz
Copy link
Contributor

tadamcz commented Feb 12, 2024

Would be great to get this into the next major version!

@foarsitter
Copy link
Contributor

@craiga I know it has been a while but I think this PR is a good candidate for the 5.0 release. Are you willing to and do you have time to rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoftDelete is an anti-pattern
3 participants