Support auditing binary model fields instead of throwing error #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When diffing model fields that are binary, represent their value as a hex representation.
Prior to this change, all fields that are not datetime or JSON will be passed to Django's
smart_str
/force_str
from within django-auditlog'sget_field_value
.The value will then be encoded as a utf8 string, which does not work for all binary values, as they may contain arbitrary bytes - for example a md5 sum or a raster image.
This commit introduces a new special handling for the values of
BinaryField
. The value will be converted to the hex representation of the binary. Hex was chosen over the default Python representation with\x
escape characters to save some space from excessive\x
in the generated string for the audit diff.Example error that motivated this PR: