Adding Foriegn Key Only Fields #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the changes JSON for a LogEntry, following relations (e.g. `ForeigKey` fields) can resutl in a significant performance penalty. This commit adds support for only logging to foreign key value, by specifying fields to log in this manner wiht a `fk_only_fields` when registering a model with the audit log.
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
+ Coverage 82.20% 82.49% +0.28%
==========================================
Files 18 18
Lines 489 497 +8
==========================================
+ Hits 402 410 +8
Misses 87 87
Continue to review full report at Codecov.
|
|
Thank you @ndwhelan for your PR. Can you please rebase it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the changes JSON for a LogEntry, following
relations (e.g.
ForeigKeyfields) can resutl in asignificant performance penalty. This commit adds support for
only logging to foreign key value, by specifying
fields to log in this manner wiht a
fk_only_fieldswhen registering a model with the audit log.