-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: game, mobs (РК 3 и 4) #5
base: rk2
Are you sure you want to change the base?
Conversation
|
||
LOGGER.info(LOG_TAB_1 + ": leader: login: " + leader.getLogin() + ", id=" + leader.getId()); | ||
|
||
final Party party = partyService.getPartyWithLeader(leader.getId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему бы парти сервису самому не сходить в акксервис если надо
|
||
|
||
|
||
public class GameConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ресурсная система?
@Override | ||
public void gmStep(long frameTime) { | ||
|
||
while (!tasks.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Что будет если очередь никогда не будет пустой?
|
||
@Component | ||
@Service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Какая разница между Component и Service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Никакой, это была попытка заставить работать шедульку. Потом обнаружил проблему, все заработало. Исправлю, я согласен, по логике это компонента.
this.mobService = mobService; | ||
} | ||
|
||
@Scheduled(fixedRate = 3600000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Точно это нужно хардкодить?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
конечно, нет. Это временная мера. Будет вынесено в конфиг.
import java.util.concurrent.ConcurrentLinkedQueue; | ||
|
||
|
||
@Service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем это сервис если вы этот объект инстанциируете потом?
Травис починить не забудьте |
No description provided.