Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: game, mobs (РК 3 и 4) #5

Open
wants to merge 2 commits into
base: rk2
Choose a base branch
from
Open

feature: game, mobs (РК 3 и 4) #5

wants to merge 2 commits into from

Conversation

adkuz
Copy link
Contributor

@adkuz adkuz commented May 31, 2018

No description provided.


LOGGER.info(LOG_TAB_1 + ": leader: login: " + leader.getLogin() + ", id=" + leader.getId());

final Party party = partyService.getPartyWithLeader(leader.getId());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему бы парти сервису самому не сходить в акксервис если надо




public class GameConfig {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ресурсная система?

@Override
public void gmStep(long frameTime) {

while (!tasks.isEmpty()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что будет если очередь никогда не будет пустой?


@Component
@Service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Какая разница между Component и Service?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Никакой, это была попытка заставить работать шедульку. Потом обнаружил проблему, все заработало. Исправлю, я согласен, по логике это компонента.

this.mobService = mobService;
}

@Scheduled(fixedRate = 3600000)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно это нужно хардкодить?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

конечно, нет. Это временная мера. Будет вынесено в конфиг.

import java.util.concurrent.ConcurrentLinkedQueue;


@Service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем это сервис если вы этот объект инстанциируете потом?

@Badya
Copy link

Badya commented May 31, 2018

Травис починить не забудьте

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants