Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: macOS tests & use LIBS instead of LDFLAGS #1

Open
wants to merge 2 commits into
base: portable_python
Choose a base branch
from
Open

fix: macOS tests & use LIBS instead of LDFLAGS #1

wants to merge 2 commits into from

Commits on Nov 10, 2024

  1. fix: macOS tests

    @mayeut
    mayeut committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    21938ed View commit details
    Browse the repository at this point in the history

  2. fix: use LIBS instead of LDFLAGS 

    LDFLAGS applies to everything including later user builds (e.g. building a wheel)
LDFLAGS_NODIST could be used but is probably unnecessary (also applies to cpython stdlib C modules which is probably unwanted)
LIBS only applies to the python executable and libpython library, this is most likely enough. https://docs.python.org/3/using/configure.html#envvar-LIBS
    @mayeut
    mayeut committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    2733e1b View commit details
    Browse the repository at this point in the history