Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make validateField return type consistent #4013

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sumtsui
Copy link

@sumtsui sumtsui commented Dec 8, 2024

The validateField function now consistently returns Promise<string | undefined>, where string represents a validation error message, undefined represents a successful validation.

before this change:

  • validation via <Field validate={...}> returned Promise<string | undefined>
  • validation via schema returned Promise<void>

Closes #2021

Copy link

changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: 4362233

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Patch
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
formik-docs ⬜️ Ignored (Inspect) Visit Preview Dec 8, 2024 4:41am

Copy link

codesandbox-ci bot commented Dec 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return value for validateField
1 participant