Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make typings compatible with v19 #4012

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Philipp91
Copy link

Fixes #4011.

To test this, I ran yarn install locally and verified that the aforementioned dist files no longer reference global JSX, but use React.JSX instead.

Fixes jaredpalmer#4011.

This is for compatibility with React v19, where the global JSX namespace went away.
Copy link

changeset-bot bot commented Dec 7, 2024

⚠️ No Changeset found

Latest commit: b405a5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 3:28pm

Copy link

codesandbox-ci bot commented Dec 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Hatko
Copy link

Hatko commented Dec 20, 2024

@jaredpalmer @quantizor Could you please take a look? The PR seems to be very small to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With React 19 typings: Cannot find namespace 'JSX'.
2 participants