-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make formik sync when validation functions are sync #3976
Open
fbarbare
wants to merge
10
commits into
jaredpalmer:main
Choose a base branch
from
plentific:fb/make-formik-synchronous-when-validation-functions-are-sync
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+760
−207
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0e6e8b0
Make formik sync when validation functions are sync
fbarbare b213069
Fix types
fbarbare 1c6c3e6
Update type
fbarbare 85b015e
Fix bug when initializing the form when validation is synchronous
fbarbare 53c660b
Merge pull request #2 from plentific/fb/bug-when-initializing-form-wh…
fbarbare fc0954c
Fix issue and add more tests for form reinitialization
fbarbare 55d4a73
Merge branch 'main' into fb/make-formik-synchronous-when-validation-f…
fbarbare d0389d2
Adding the changeset
fbarbare 9ae9a55
Merge branch 'main' into fb/make-formik-synchronous-when-validation-f…
fbarbare a0b17a6
Merge branch 'main' into fb/make-formik-synchronous-when-validation-f…
fbarbare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'formik': minor | ||
--- | ||
|
||
Formik might not need to run asynchronously, it all depends on the validation functions. This change makes it all run synchronously if the validation functions do not return any promise, making all the updates much faster and creating les re-renders. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quantizor we might want to make this a major version bumb in the end.
I had not thought of that initially but if anyone implemented things as
setFieldValue(..).catch(...)
then it would break if their validation functions would be sync. It would be completely fine if they would implement it asawait setFieldValue(..)
orvoid setFieldValue(..)
though.What are your thoughts?