Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Margin Issue with Lg screen #3903

Closed

Conversation

webdev-ashishk
Copy link

What does this PR do ?

fixes: #3902

Type of change made

added lg:mx-4 in two file
first file is index.tsx and second file is footer.tsx

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 694456c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 5:12pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 694456c:

Sandbox Source
Formik TypeScript Playground (forked) Configuration

@zoosphar
Copy link
Contributor

Hello @webdev-ashishk,

I noticed that you added the class lg:mx-4, which is acceptable. However, I also noticed that there are unnecessary changes in both the footer and index files. These changes involve reordering classes on the elements, which can potentially cause conflicts on the main branch when merging or when someone pulls from the origin after merging. To maintain the clarity of the solution you provided, please avoid making these changes.

Thank you.

@webdev-ashishk
Copy link
Author

Hello @webdev-ashishk,

I noticed that you added the class lg:mx-4, which is acceptable. However, I also noticed that there are unnecessary changes in both the footer and index files. These changes involve reordering classes on the elements, which can potentially cause conflicts on the main branch when merging or when someone pulls from the origin after merging. To maintain the clarity of the solution you provided, please avoid making these changes.

Thank you.

@webdev-ashishk webdev-ashishk deleted the fix/margin#3902 branch November 14, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Margin Issue with LG screen
2 participants