define a playbook to be referenced by other ansible based GPTs #133
Conversation
Signed-off-by: Ryan Cook <[email protected]>
cooktheryan
force-pushed
the
ansible-play
branch
from
1de33b1 to
aeaa920
Compare
There was a problem hiding this comment.
Hey @cooktheryan just 1 nit in 2 places + a rebase required. Otherwise lgtm.🙂
scaffolder-templates/ansible-playbook/skeleton/${{values.playbookName}}.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Cook <[email protected]>
Signed-off-by: Ryan Cook <[email protected]>
Signed-off-by: Ryan Cook <[email protected]>
|
thanks @tumido !! |
|
When I was testing this, it was surprising to me that it tried to update my existing If I understand this correctly, this is supposed to be used to add the Ansible playbook into an existing repository that would typically already be in Software Catalog. Maybe I'm missing something? |
| name: Registering the Catalog Info Component | ||
| action: catalog:register | ||
| input: | ||
| repoContentsUrl: ${{ steps.publish.output.repoContentsUrl }} |
There was a problem hiding this comment.
This is not going to work. There is no repoContentsUrl on the output of github:pull-request.
|
@kadel can you review this when you get a chance? |
| githubOrg: | ||
| title: GitHub Organization | ||
| type: string | ||
| owner: |
There was a problem hiding this comment.
this parameter can be removed, it is not used anymore
|
Register step is failing with |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What does this PR do / why we need it
Part of the ansible epic
Which issue(s) does this PR fix
Day 0 of the Ansible pipeline
Fixes #173
How to test changes / Special notes to the reviewer
This one is to just define an ansible playbook in your git repo