Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e-test): [Test automation] Verify Home Page can be customized #2035

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

teknaS47
Copy link
Contributor

@teknaS47 teknaS47 commented Dec 2, 2024

Description

Added configuration to display the various components that can be added to the Home Page including the default elements.
Added automation to test these Home Page elements to verify that the Home Page can be customized.

Video:
video.webm

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@teknaS47 teknaS47 requested a review from a team as a code owner December 2, 2024 13:01
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

I didn't checked if they pass!

@christoph-jerolimov
Copy link
Member

Someone else with QE background should add final lgtm.

/lgtm cancel

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Copy link
Contributor

github-actions bot commented Dec 3, 2024

@teknaS47
Copy link
Contributor Author

teknaS47 commented Dec 3, 2024

/test e2e-tests

1 similar comment
@teknaS47
Copy link
Contributor Author

teknaS47 commented Dec 3, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Copy link
Contributor

github-actions bot commented Dec 5, 2024

@teknaS47
Copy link
Contributor Author

teknaS47 commented Dec 5, 2024

/test e2e-tests

1 similar comment
@teknaS47
Copy link
Contributor Author

teknaS47 commented Dec 5, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Dec 9, 2024

@teknaS47
Copy link
Contributor Author

teknaS47 commented Dec 9, 2024

/test e2e-tests

3 similar comments
@teknaS47
Copy link
Contributor Author

teknaS47 commented Dec 9, 2024

/test e2e-tests

@teknaS47
Copy link
Contributor Author

/test e2e-tests

@teknaS47
Copy link
Contributor Author

/test e2e-tests

@teknaS47
Copy link
Contributor Author

/test e2e-tests

Copy link
Contributor

@christoph-jerolimov
Copy link
Member

@teknaS47 can you please rebase this PR. I guess it will solve the Node.js 20 job issue. Thank you

@teknaS47 teknaS47 force-pushed the home-page-customization branch from 874e585 to 663973a Compare December 12, 2024 05:59
Copy link
Contributor

@subhashkhileri
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c4acbb into janus-idp:main Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants