remove checkAndClickOnGHloginPopup (#1950)

janus-idp · Nov 27, 2024 · e8511c2 · e8511c2
1 parent d907bac
commit e8511c2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 15 deletions.
diff --git a/e2e-tests/playwright/e2e/github-discovery.spec.ts b/e2e-tests/playwright/e2e/github-discovery.spec.ts
@@ -23,10 +23,6 @@ const test = base.extend<GithubDiscoveryFixture>({
 });
 
 test.describe("Github Discovery Catalog", () => {
-  test.beforeEach(
-    async ({ page }) => await new Common(page).checkAndClickOnGHloginPopup(),
-  );
-
   test(`Discover Organization's Catalog`, async ({
     catalogPage,
     githubApi,

diff --git a/e2e-tests/playwright/e2e/github-integration-org-fetch.spec.ts b/e2e-tests/playwright/e2e/github-integration-org-fetch.spec.ts
@@ -13,9 +13,6 @@ test.describe.serial("GitHub integration with Org data fetching", () => {
     common = new Common(page);
     await common.loginAsGithubUser();
   });
-  test.beforeEach(
-    async () => await new Common(page).checkAndClickOnGHloginPopup(),
-  );
 
   test("Verify that fetching the groups of the first org works", async () => {
     await uiHelper.openSidebar("Catalog");

diff --git a/e2e-tests/playwright/e2e/plugins/analytics/analytics-disabled-rbac.spec.ts b/e2e-tests/playwright/e2e/plugins/analytics/analytics-disabled-rbac.spec.ts
@@ -17,10 +17,6 @@ test.describe.skip('Check RBAC "analytics-provider-segment" plugin', () => {
     await uiHelper.verifyHeading("Plugins");
   });
 
-  test.beforeEach(
-    async ({ page }) => await new Common(page).checkAndClickOnGHloginPopup(),
-  );
-
   test("is disabled", async ({ page }) => {
     await page
       .getByPlaceholder("Filter")

diff --git a/e2e-tests/playwright/e2e/verify-tls-config-with-external-postgres-db.spec.ts b/e2e-tests/playwright/e2e/verify-tls-config-with-external-postgres-db.spec.ts
@@ -3,10 +3,6 @@ import { UIhelper } from "../utils/UIhelper";
 import { Common } from "../utils/Common";
 
 test.describe("Verify TLS configuration with external Postgres DB", () => {
-  test.beforeEach(
-    async ({ page }) => await new Common(page).checkAndClickOnGHloginPopup(),
-  );
-
   test("Verify successful DB connection and display of expected entities in the Catalog", async ({
     page,
   }) => {