-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle update #66
Open
mudassarwurfel
wants to merge
28
commits into
janishar:development
Choose a base branch
from
mudassarwurfel:gradle_update
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gradle update #66
mudassarwurfel
wants to merge
28
commits into
janishar:development
from
mudassarwurfel:gradle_update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseViewModel holds hard reference to Navigators which can lead to le…
Update gradle version Update gradle plugin version
Update gradle stuff
Allow cleartext communication with mocky.io
…-about-parent Replace constraint layout with linear layout in about fragment
…elFactory Common view model factory
…elFactory Add constructor injection for VMFactory
Prevent LiveData exposure to UI. Binding Livedata to recyclerview
Moving mapping of open source response to background.
Initial commit
…d_vminjections Remove unwanted VM injection from OpenSourceFragment Module and BlogF…
Singleton factory
Do RxJava for Room
…as been removed (destination "$yourpath" replaced with destination file("$yourpath")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle version Updated -> in Gradle 5.x setDestination(Object file) has been removed (destination "$yourpath" replaced with destination file("$yourpath")