Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent LiveData exposure to UI. Binding Livedata to recyclerview #50

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Prevent LiveData exposure to UI. Binding Livedata to recyclerview #50

merged 1 commit into from
Mar 1, 2019

Conversation

Vignesh150493
Copy link
Contributor

  • Views - should not be able to update LiveData and thus their own state because that’s the
    responsibility of ViewModels. Views should be able to only observe LiveData.
  • Setting the LifecycleOwner that should be used for observing changes of
    LiveData in this binding. We do not need to maintain an observableArrayList.
  • These changes have been done in blog and opensource fragments for a start.

@Vignesh150493
Copy link
Contributor Author

I think this addresses #35

jyotid
jyotid requested changes Mar 1, 2019
View reviewed changes
Copy link
Collaborator

@jyotid jyotid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking back my comment :P Understood it other way

@amitshekhariitbhu amitshekhariitbhu merged commit 186c446 into janishar:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyotid jyotid jyotid requested changes

@amitshekhariitbhu amitshekhariitbhu amitshekhariitbhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vignesh150493 @amitshekhariitbhu @jyotid